duuqnd/cave-story-solaris
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove invalid comments

Browse source 
These issues are fixed in this branch
This commit is contained in:
Clownacy 2020-04-06 13:57:54 +01:00
parent 12e4be58ac
commit 40d0cf14f1
5 changed files with 0 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/Bullet.cpp
View file

@ -1664,8 +1664,6 @@ void ActBullet_Edge(BULLET *bul)
{96, 88, 120, 112}, {96, 88, 120, 112},
}; };
// Note that 'bul->ani_no' can exceed the size of 'rcLeft' and 'rcRight'
if (bul->direct == 0) if (bul->direct == 0)
bul->rect = rcLeft[bul->ani_no]; bul->rect = rcLeft[bul->ani_no];
else else

8
src/Caret.cpp
View file

@ -79,8 +79,6 @@ void ActCaret01(CARET *crt)
} }
} }
// Note that 'crt->ani_no' can exceed the size of 'rcLeft' and 'rcRight'
if (crt->direct == 0) if (crt->direct == 0)
crt->rect = rcLeft[crt->ani_no]; crt->rect = rcLeft[crt->ani_no];
else else
@ -256,8 +254,6 @@ void ActCaret07(CARET *crt)
} }
} }
// Note that 'crt->ani_no' can exceed the size of rcLeft
crt->rect = rcLeft[crt->ani_no]; crt->rect = rcLeft[crt->ani_no];
switch (crt->direct) switch (crt->direct)
@ -465,8 +461,6 @@ void ActCaret14(CARET *crt)
} }
} }
// Note that 'crt->ani_no' can exceed the size of 'rect'
crt->rect = rect[crt->ani_no]; crt->rect = rect[crt->ani_no];
} }
@ -490,8 +484,6 @@ void ActCaret15(CARET *crt)
} }
} }
// Note that 'crt->ani_no' can exceed the size of 'rcLeft'
crt->rect = rcLeft[crt->ani_no]; crt->rect = rcLeft[crt->ani_no];
} }

6
src/NpcAct120.cpp
View file

@ -591,8 +591,6 @@ void ActNpc127(NPCHAR *npc)
} }
} }
// Note that 'npc->ani_no' can exceed the size of 'rcH' and 'rcV'
if (npc->direct == 0) if (npc->direct == 0)
npc->rect = rcH[npc->ani_no]; npc->rect = rcH[npc->ani_no];
else else
@ -656,8 +654,6 @@ void ActNpc128(NPCHAR *npc)
return; // Prevent UB at rc[npc->ani_no] when npc->ani_no == 5 return; // Prevent UB at rc[npc->ani_no] when npc->ani_no == 5
} }
// Note that 'npc->ani_no' can exceed the bounds of 'rcLeft', 'rcUp', 'rcRight' and 'rcDown'
switch (npc->direct) switch (npc->direct)
{ {
case 0: case 0:
@ -715,8 +711,6 @@ void ActNpc129(NPCHAR *npc)
npc->y += npc->ym; npc->y += npc->ym;
// Note that '(npc->direct * 3) + npc->ani_no' can exceed the size of 'rect'
npc->rect = rect[(npc->direct * 3) + npc->ani_no]; npc->rect = rect[(npc->direct * 3) + npc->ani_no];
} }

1
src/NpcAct140.cpp
View file

@ -759,7 +759,6 @@ void ActNpc146(NPCHAR *npc)
break; break;
} }
// Note that 'npc->ani_no' can exceed the size of 'rect'
npc->rect = rect[npc->ani_no]; npc->rect = rect[npc->ani_no];
} }

1
src/NpcAct180.cpp
View file

@ -1434,6 +1434,5 @@ void ActNpc199(NPCHAR *npc)
npc->x += npc->xm; npc->x += npc->xm;
npc->y += npc->ym; npc->y += npc->ym;
// Note that 'npc->ani_no' can exceed the size of 'rect'
npc->rect = rect[npc->ani_no]; npc->rect = rect[npc->ani_no];
} }