Made signed chars explicit

The default sign varies between hardware.

Text seems to always be ambiguously 'char', so I've left those
This commit is contained in:
Clownacy 2019-05-06 20:04:47 +01:00
parent 6816f92b6d
commit 421a3c46cd
7 changed files with 14 additions and 14 deletions

View file

@ -16,9 +16,9 @@ struct FADE
int mode; int mode;
BOOL bMask; BOOL bMask;
int count; int count;
char ani_no[FADE_HEIGHT][FADE_WIDTH]; signed char ani_no[FADE_HEIGHT][FADE_WIDTH];
char flag[FADE_HEIGHT][FADE_WIDTH]; // Not a BOOLEAN (those are unsigned) signed char flag[FADE_HEIGHT][FADE_WIDTH]; // Not a BOOLEAN (those are unsigned)
char dir; signed char dir;
}; };
static FADE gFade; static FADE gFade;
@ -41,7 +41,7 @@ void ClearFade()
gFade.mode = 0; gFade.mode = 0;
} }
void StartFadeOut(char dir) void StartFadeOut(signed char dir)
{ {
gFade.mode = 2; gFade.mode = 2;
gFade.count = 0; gFade.count = 0;
@ -58,7 +58,7 @@ void StartFadeOut(char dir)
} }
} }
void StartFadeIn(char dir) void StartFadeIn(signed char dir)
{ {
int x; int x;
int y; int y;

View file

@ -5,8 +5,8 @@
void InitFade(); void InitFade();
void SetFadeMask(); void SetFadeMask();
void ClearFade(); void ClearFade();
void StartFadeOut(char dir); void StartFadeOut(signed char dir);
void StartFadeIn(char dir); void StartFadeIn(signed char dir);
void ProcFade(); void ProcFade();
void PutFade(); void PutFade();
BOOL GetFadeActive(); BOOL GetFadeActive();

View file

@ -303,7 +303,7 @@ void ChangeDramVolume(int32_t volume, int8_t track)
lpDRAMBUFFER[track]->SetVolume((volume - 0xFF) * 8); lpDRAMBUFFER[track]->SetVolume((volume - 0xFF) * 8);
} }
void PlayDramObject(unsigned char key, int mode,char track) void PlayDramObject(unsigned char key, int mode, signed char track)
{ {
switch(mode) switch(mode)
{ {

View file

@ -56,7 +56,7 @@ void MakeWaveTables(void)
// White noise wave // White noise wave
rep_srand(0); rep_srand(0);
for (i = 0; i < 256; ++i) for (i = 0; i < 256; ++i)
gWaveModelTable[5][i] = (char)(rep_rand() & 0xFF) / 2; gWaveModelTable[5][i] = (signed char)(rep_rand() & 0xFF) / 2;
} }
BOOL MakePixelWaveData(const PIXTONEPARAMETER *ptp, unsigned char *pData) BOOL MakePixelWaveData(const PIXTONEPARAMETER *ptp, unsigned char *pData)

View file

@ -25,7 +25,7 @@ struct PROFILE
ARMS arms[8]; ARMS arms[8];
ITEM items[32]; ITEM items[32];
PERMIT_STAGE permitstage[8]; PERMIT_STAGE permitstage[8];
char permit_mapping[0x80]; signed char permit_mapping[0x80];
char FLAG[4]; char FLAG[4];
uint8_t flags[1000]; uint8_t flags[1000];
}; };

View file

@ -10,7 +10,7 @@ struct STAGE_TABLE
char back[0x20]; char back[0x20];
char npc[0x20]; char npc[0x20];
char boss[0x20]; char boss[0x20];
char boss_no; signed char boss_no;
char name[0x20]; char name[0x20];
}; };

View file

@ -16,10 +16,10 @@ struct TEXT_SCRIPT
char *data; char *data;
//Mode (ex. NOD, WAI) //Mode (ex. NOD, WAI)
char mode; signed char mode;
//Flags //Flags
char flags; signed char flags;
//Current positions (read position in buffer, x position in line) //Current positions (read position in buffer, x position in line)
unsigned int p_read; unsigned int p_read;
@ -37,7 +37,7 @@ struct TEXT_SCRIPT
int next_event; int next_event;
//Yes/no selected //Yes/no selected
char select; signed char select;
//Current face //Current face
int face; int face;