From f7a3eee9b511301e89ec0d62a83bea218f2e57a2 Mon Sep 17 00:00:00 2001 From: Gabriel Ravier Date: Sun, 10 Nov 2019 13:09:05 +0100 Subject: [PATCH] betterComments : Some stuff for the PR to accurate Signed-off-by: Gabriel Ravier --- src/NpcAct160.cpp | 4 ++-- src/NpcAct260.cpp | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/NpcAct160.cpp b/src/NpcAct160.cpp index d1a45646..606bbee3 100644 --- a/src/NpcAct160.cpp +++ b/src/NpcAct160.cpp @@ -69,8 +69,8 @@ void ActNpc160(NPCHAR *npc) break; case 3: - npc->damage = 20; - npc->damage = 0; // Duplicate line + npc->damage = 20; // Overriden by the following line + npc->damage = 0; if (++npc->act_wait > 24) { diff --git a/src/NpcAct260.cpp b/src/NpcAct260.cpp index db398856..2460aa4f 100644 --- a/src/NpcAct260.cpp +++ b/src/NpcAct260.cpp @@ -1291,8 +1291,6 @@ void ActNpc268(NPCHAR *npc) case 51: if (++npc->act_wait > 30 && npc->act_wait % 4 == 1) { - // The range of unsigned char is [0, 255] so these two values are implicitly truncated (Might be UB ?) - // TODO : Investigate on whether this is erroneous if (npc->direct == 0) deg = 0x88; else