duuqnd/cave-story-solaris
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
1134 commits 1 branch 0 tags 64 MiB
Commit graph

1134 commits

This branch
This branch
All branches
Author SHA1 Message Date
Clownacy
01db50d0e7
Merge pull request #75 from GabrielRavier/betterComments 
Improved quite a few comments
 2019-11-10 12:14:25 +00:00
Gabriel Ravier
f7a3eee9b5 betterComments : Some stuff for the PR to accurate 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-10 13:09:05 +01:00
Gabriel Ravier
9461b141f1 Documentation : Removed comment which talks about an issue fixed by commit e34f492418 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-09 23:39:28 +01:00
Gabriel Ravier
058881e4eb Documentation : Tried to clarify comment on random conversion to short 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-09 23:37:10 +01:00
Gabriel Ravier
5b18283e5f Documentation : Made some comments clearer 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-09 23:37:10 +01:00
Gabriel Ravier
f840be28c7 Added better comment for random self-assign in Fade.cpp 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-09 23:37:10 +01:00
Gabriel Ravier
17f7f66fc9 Documentation : Comment an always true expression 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-09 23:37:10 +01:00
Gabriel Ravier
ffc6e3e75b Documentation : Comment duplicate line 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-09 23:36:09 +01:00
Gabriel Ravier
512b2e4951 Documentation : Comment always true condition 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-09 23:36:09 +01:00
Gabriel Ravier
a45592302f Documentation : Commented the fact that "swPlay % 2" is always true 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-09 23:36:09 +01:00
Gabriel Ravier
32d29eb63e Documentation : Note that the fact 96 is already listed results in the condition always being false 2019-11-09 23:36:09 +01:00
Gabriel Ravier
ab4a265cd9 Documentation : Add note about duplicate block of code 2019-11-09 23:36:09 +01:00
Gabriel Ravier
6b1f82e78e Documentation : Document identical function bodies for InitBullet and ClearBullet 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-09 23:36:09 +01:00
Gabriel Ravier
bda9fc391a Documentation : Comment redundant if 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-09 23:36:09 +01:00
Gabriel Ravier
6635cc58ed Documentation : Comment identical case branches in NpcAct280 2019-11-09 23:36:09 +01:00
Gabriel Ravier
6f0ffe546f Documentation : Add note about identical case branches in NpcAct020 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-09 23:36:09 +01:00
Gabriel Ravier
c9e63c7694 Documentation : Document the identical HitMyCharMap case branches 2019-11-09 23:36:08 +01:00
Gabriel Ravier
1891591586 Documentation : Document identical case branches in ActBullet 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-09 23:36:08 +01:00
Gabriel Ravier
7ddcbfaa73 Add note about identical case branches 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-09 23:36:08 +01:00
Gabriel Ravier
347f9282fe Documentation : Commented redundant check 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-09 23:36:08 +01:00
Gabriel Ravier
073a15b41b Documentation : Comment implicit truncation 2019-11-09 23:36:08 +01:00
Gabriel Ravier
fa304081fe Documentation : Add note about irreproductability of __DATE 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-09 23:36:08 +01:00
Clownacy
9c56888ffd Deobfuscare more values 2019-11-09 15:40:15 +00:00
Clownacy
9df9ea76f6 Deobfuscate some code 
Still ASM-accurate
 2019-11-09 15:19:34 +00:00
Clownacy
266bb13be2 Compare some pointers to NULL 
Doesn't affect ASM-accuracy - I just think it looks neater.
 2019-11-09 14:53:34 +00:00
Clownacy
5026964d98 Fix some more incorrectly-decompiled code 2019-11-09 14:48:11 +00:00
Clownacy
e34f492418 Accuracy fixes for Igor 
Includes an ASM-accuracy fix I somehow missed before.
 2019-11-09 14:39:23 +00:00
Clownacy
cb87f05057
Merge pull request #77 from GabrielRavier/cmpUnclear 
Make cmp usage clearer
 2019-11-09 14:05:04 +00:00
Clownacy
bac98f7402
Merge pull request #81 from GabrielRavier/surroundMacroWithParentheses 
Surrounded the IS_COMMAND macro with parentheses
 2019-11-09 14:00:14 +00:00
Clownacy
69ec37c1cc
Merge pull request #82 from GabrielRavier/correctEnumTypeBeingConvertedToBool 
Check "no" against MUS_SILENCE instead of converting it to a bool
 2019-11-09 13:54:42 +00:00
Gabriel Ravier
401a8f0d42 Bug : Fix wrong == to != 2019-11-06 20:21:56 +01:00
Gabriel Ravier
571a7ca723 Bug : Put parentheses around IS_COMMAND and its parameters 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-05 17:33:16 +01:00
Gabriel Ravier
bae879e3b5 Check "no" against MUS_SILENCE instead of converting it to a bool 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-05 17:27:04 +01:00
Gabriel Ravier
f96b7fa566 Use "memcmp(a, b) != 0" instead of "memcmp(a, b)" so it's clearer we're searching for a difference 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-05 17:25:08 +01:00
Gabriel Ravier
053770b81b Use "strcmp(a, b) != 0" so it's clearer what we're checking for 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-05 10:51:32 +01:00
Gabriel Ravier
3c920996b8 Make memcmp usage clearer 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-05 10:43:09 +01:00
Clownacy
4e322f25c4
Merge pull request #74 from GabrielRavier/parenthesizeFlagsMacros 
Parenthesize flag macros
 2019-11-04 19:08:30 +00:00
Clownacy
6408303c53
Merge pull request #71 from GabrielRavier/removeNonExistentNameCollisions 
Remove undefs in WindowsWrapper
 2019-11-04 19:05:56 +00:00
Gabriel Ravier
adc4f99c5a Remove the undefs in WindowsWrapper, as these have no purpose here (no collisions with accurate) 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-04 15:07:20 +01:00
Gabriel Ravier
159bc5d869 Documentation : Make operator priority clearer) 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-04 11:42:34 +01:00
Clownacy
a25998f113 Add actual dependencies to the .rc file 2019-10-29 18:55:15 +00:00
Clownacy
7f2499243c Add a 'compiling resources' message to Makefile 2019-10-29 18:43:52 +00:00
Clownacy
f596f89736 Shut up more Clang warnings 2019-10-29 12:20:48 +00:00
Clownacy
567330cc5b Remove some trailing commas 
According to Clang, they're not valid C++98
 2019-10-29 12:11:07 +00:00
Clownacy
9fb01161c3 Swap two function calls around 
This matches the original EXE. I didn't catch it while doing the
ASM-accuracy checks because absolute addresses don't match yet.

Thanks to Gabe for noticing this.
 2019-10-26 23:40:32 +01:00
Clownacy
b1418f7fae Remove a leftover unsigned literal 2019-10-21 19:33:49 +01:00
Clownacy
f690f9907d Convert some old Shift-JIS comments to UTF-8 2019-10-21 19:28:21 +01:00
Clownacy
f6dd58429e Add missing boolean values 2019-10-21 19:25:34 +01:00
Clownacy
dda0dd2fac Fix mismatching function declaration in header 
Noticed this while trying to compile CSE2 with winelib.
 2019-10-21 18:56:26 +01:00
Clownacy
a8cf5e1846 Fix a typo in a comment 2019-10-20 21:08:47 +00:00