Gabriel Ravier
5b18283e5f
Documentation : Made some comments clearer
...
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-09 23:37:10 +01:00
Gabriel Ravier
f840be28c7
Added better comment for random self-assign in Fade.cpp
...
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-09 23:37:10 +01:00
Gabriel Ravier
17f7f66fc9
Documentation : Comment an always true expression
...
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-09 23:37:10 +01:00
Gabriel Ravier
ffc6e3e75b
Documentation : Comment duplicate line
...
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-09 23:36:09 +01:00
Gabriel Ravier
512b2e4951
Documentation : Comment always true condition
...
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-09 23:36:09 +01:00
Gabriel Ravier
a45592302f
Documentation : Commented the fact that "swPlay % 2" is always true
...
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-09 23:36:09 +01:00
Gabriel Ravier
32d29eb63e
Documentation : Note that the fact 96 is already listed results in the condition always being false
2019-11-09 23:36:09 +01:00
Gabriel Ravier
ab4a265cd9
Documentation : Add note about duplicate block of code
2019-11-09 23:36:09 +01:00
Gabriel Ravier
6b1f82e78e
Documentation : Document identical function bodies for InitBullet and ClearBullet
...
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-09 23:36:09 +01:00
Gabriel Ravier
bda9fc391a
Documentation : Comment redundant if
...
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-09 23:36:09 +01:00
Gabriel Ravier
6635cc58ed
Documentation : Comment identical case branches in NpcAct280
2019-11-09 23:36:09 +01:00
Gabriel Ravier
6f0ffe546f
Documentation : Add note about identical case branches in NpcAct020
...
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-09 23:36:09 +01:00
Gabriel Ravier
c9e63c7694
Documentation : Document the identical HitMyCharMap case branches
2019-11-09 23:36:08 +01:00
Gabriel Ravier
1891591586
Documentation : Document identical case branches in ActBullet
...
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-09 23:36:08 +01:00
Gabriel Ravier
7ddcbfaa73
Add note about identical case branches
...
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-09 23:36:08 +01:00
Gabriel Ravier
347f9282fe
Documentation : Commented redundant check
...
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-09 23:36:08 +01:00
Gabriel Ravier
073a15b41b
Documentation : Comment implicit truncation
2019-11-09 23:36:08 +01:00
Gabriel Ravier
fa304081fe
Documentation : Add note about irreproductability of __DATE
...
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-09 23:36:08 +01:00
Clownacy
9c56888ffd
Deobfuscare more values
2019-11-09 15:40:15 +00:00
Clownacy
9df9ea76f6
Deobfuscate some code
...
Still ASM-accurate
2019-11-09 15:19:34 +00:00
Clownacy
266bb13be2
Compare some pointers to NULL
...
Doesn't affect ASM-accuracy - I just think it looks neater.
2019-11-09 14:53:34 +00:00
Clownacy
5026964d98
Fix some more incorrectly-decompiled code
2019-11-09 14:48:11 +00:00
Clownacy
e34f492418
Accuracy fixes for Igor
...
Includes an ASM-accuracy fix I somehow missed before.
2019-11-09 14:39:23 +00:00
Clownacy
8344716548
Merge branch 'accurate' into portable
2019-11-09 14:24:55 +00:00
Clownacy
3c9ff22c22
Add better error-handling to Font.cpp
...
Co-authored-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-09 14:19:26 +00:00
Clownacy
cb87f05057
Merge pull request #77 from GabrielRavier/cmpUnclear
...
Make cmp usage clearer
2019-11-09 14:05:04 +00:00
Clownacy
bac98f7402
Merge pull request #81 from GabrielRavier/surroundMacroWithParentheses
...
Surrounded the IS_COMMAND macro with parentheses
2019-11-09 14:00:14 +00:00
Gabriel Ravier
401a8f0d42
Bug : Fix wrong ==
to !=
2019-11-06 20:21:56 +01:00
Gabriel Ravier
571a7ca723
Bug : Put parentheses around IS_COMMAND and its parameters
...
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-05 17:33:16 +01:00
Gabriel Ravier
bae879e3b5
Check "no" against MUS_SILENCE instead of converting it to a bool
...
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-05 17:27:04 +01:00
Gabriel Ravier
f96b7fa566
Use "memcmp(a, b) != 0" instead of "memcmp(a, b)" so it's clearer we're searching for a difference
...
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-05 17:25:08 +01:00
Gabriel Ravier
053770b81b
Use "strcmp(a, b) != 0" so it's clearer what we're checking for
...
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-05 10:51:32 +01:00
Gabriel Ravier
3c920996b8
Make memcmp usage clearer
...
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-05 10:43:09 +01:00
Clownacy
4e322f25c4
Merge pull request #74 from GabrielRavier/parenthesizeFlagsMacros
...
Parenthesize flag macros
2019-11-04 19:08:30 +00:00
Gabriel Ravier
adc4f99c5a
Remove the undefs in WindowsWrapper, as these have no purpose here (no collisions with accurate)
...
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-04 15:07:20 +01:00
Gabriel Ravier
159bc5d869
Documentation : Make operator priority clearer)
...
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-04 11:42:34 +01:00
Clownacy
01c5fb3a37
Shut up another warning
2019-10-29 12:25:03 +00:00
Clownacy
394d5658a4
Merge branch 'accurate' into portable
2019-10-29 12:21:02 +00:00
Clownacy
f596f89736
Shut up more Clang warnings
2019-10-29 12:20:48 +00:00
Clownacy
011b79a051
Shut up some more Clang warnings
2019-10-29 12:20:05 +00:00
Clownacy
85890ef1e6
Shut up some Clang warnings
2019-10-29 12:14:48 +00:00
Clownacy
ba1361abd5
Merge branch 'accurate' into portable
2019-10-29 12:11:35 +00:00
Clownacy
567330cc5b
Remove some trailing commas
...
According to Clang, they're not valid C++98
2019-10-29 12:11:07 +00:00
Clownacy
6b98bffba1
Remove mutex_name
...
It's unused outside of the accurate branch. Maybe someday I'll port
the mutex behaviour.
2019-10-29 12:01:49 +00:00
Clownacy
c2daebe38a
Handle Backend_Init failing
...
Should really give those render-backend functions a different prefix.
2019-10-27 01:57:09 +00:00
Clownacy
785131a184
Merge branch 'accurate' into portable
2019-10-26 23:47:06 +01:00
Clownacy
9fb01161c3
Swap two function calls around
...
This matches the original EXE. I didn't catch it while doing the
ASM-accuracy checks because absolute addresses don't match yet.
Thanks to Gabe for noticing this.
2019-10-26 23:40:32 +01:00
Clownacy
67ddb8204b
...Maybe I should test these things first
2019-10-26 02:21:49 +01:00
Clownacy
ae8437009d
Correct return values in OpenGL3's Backend_Init
2019-10-26 01:54:43 +01:00
Clownacy
006a20b914
Merge branch 'accurate' into portable
2019-10-21 20:25:48 +01:00