duuqnd/cave-story-solaris
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
1259 commits 1 branch 0 tags 64 MiB
Commit graph

1259 commits

This branch
This branch
All branches
Author SHA1 Message Date
Clownacy
5026964d98 Fix some more incorrectly-decompiled code 2019-11-09 14:48:11 +00:00
Clownacy
e34f492418 Accuracy fixes for Igor 
Includes an ASM-accuracy fix I somehow missed before.
 2019-11-09 14:39:23 +00:00
Clownacy
cb87f05057
Merge pull request #77 from GabrielRavier/cmpUnclear 
Make cmp usage clearer
 2019-11-09 14:05:04 +00:00
Clownacy
bac98f7402
Merge pull request #81 from GabrielRavier/surroundMacroWithParentheses 
Surrounded the IS_COMMAND macro with parentheses
 2019-11-09 14:00:14 +00:00
Clownacy
69ec37c1cc
Merge pull request #82 from GabrielRavier/correctEnumTypeBeingConvertedToBool 
Check "no" against MUS_SILENCE instead of converting it to a bool
 2019-11-09 13:54:42 +00:00
Gabriel Ravier
401a8f0d42 Bug : Fix wrong == to != 2019-11-06 20:21:56 +01:00
Gabriel Ravier
571a7ca723 Bug : Put parentheses around IS_COMMAND and its parameters 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-05 17:33:16 +01:00
Gabriel Ravier
bae879e3b5 Check "no" against MUS_SILENCE instead of converting it to a bool 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-05 17:27:04 +01:00
Gabriel Ravier
f96b7fa566 Use "memcmp(a, b) != 0" instead of "memcmp(a, b)" so it's clearer we're searching for a difference 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-05 17:25:08 +01:00
Gabriel Ravier
053770b81b Use "strcmp(a, b) != 0" so it's clearer what we're checking for 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-05 10:51:32 +01:00
Gabriel Ravier
3c920996b8 Make memcmp usage clearer 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-05 10:43:09 +01:00
Clownacy
4e322f25c4
Merge pull request #74 from GabrielRavier/parenthesizeFlagsMacros 
Parenthesize flag macros
 2019-11-04 19:08:30 +00:00
Clownacy
6408303c53
Merge pull request #71 from GabrielRavier/removeNonExistentNameCollisions 
Remove undefs in WindowsWrapper
 2019-11-04 19:05:56 +00:00
Gabriel Ravier
adc4f99c5a Remove the undefs in WindowsWrapper, as these have no purpose here (no collisions with accurate) 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-04 15:07:20 +01:00
Gabriel Ravier
159bc5d869 Documentation : Make operator priority clearer) 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-11-04 11:42:34 +01:00
Clownacy
a25998f113 Add actual dependencies to the .rc file 2019-10-29 18:55:15 +00:00
Clownacy
7f2499243c Add a 'compiling resources' message to Makefile 2019-10-29 18:43:52 +00:00
Clownacy
f596f89736 Shut up more Clang warnings 2019-10-29 12:20:48 +00:00
Clownacy
567330cc5b Remove some trailing commas 
According to Clang, they're not valid C++98
 2019-10-29 12:11:07 +00:00
Clownacy
9fb01161c3 Swap two function calls around 
This matches the original EXE. I didn't catch it while doing the
ASM-accuracy checks because absolute addresses don't match yet.

Thanks to Gabe for noticing this.
 2019-10-26 23:40:32 +01:00
Clownacy
b1418f7fae Remove a leftover unsigned literal 2019-10-21 19:33:49 +01:00
Clownacy
f690f9907d Convert some old Shift-JIS comments to UTF-8 2019-10-21 19:28:21 +01:00
Clownacy
f6dd58429e Add missing boolean values 2019-10-21 19:25:34 +01:00
Clownacy
dda0dd2fac Fix mismatching function declaration in header 
Noticed this while trying to compile CSE2 with winelib.
 2019-10-21 18:56:26 +01:00
Clownacy
a8cf5e1846 Fix a typo in a comment 2019-10-20 21:08:47 +00:00
Clownacy
a9265e8b45 Fix some errors when compiled with Visual Studio 6 
Thanks to Mint for testing VS6. The compiler would complain about
the declaration of these variables being skipped by the switch's
labels. Pretty sure this is perfectly-legal C++98, but whatever.

...

Stupid old compilers.
 2019-10-17 00:47:25 +01:00
Clownacy
764df530ad Made TextScr.cpp's 'text' array two-dimensional 
This is still ASM-accurate, and much more readable. This is likely
how it was in the original source code.

Fixes #56
 2019-10-16 15:31:39 +01:00
Clownacy
cea39ac06b
Improve the readme's wording some more 
I was never much of a storyteller.
 2019-10-14 22:45:42 +00:00
Clownacy
253b33d34f Turns out this isn't debug-related 
Or if it was, it was repurposed: <NUM is used by the 'you got X
missiles' script.
 2019-10-14 21:00:04 +00:00
Clownacy
883f5470db Remove leftover bin2h stuff from Makefile 2019-10-13 01:55:40 +00:00
Clownacy
aad7e41ded Remove leftover DoConfig stuff from the Makefile 2019-10-13 01:46:27 +00:00
Clownacy
709065d716 Use a sizeof instead of this raw value 2019-10-12 16:54:58 +00:00
Clownacy
869bff3da1 These values are arbitrary, not the screen size 2019-10-12 16:41:40 +00:00
Clownacy
591236398f ...And don't break the indentation 
Am I rusty, or something? Jeez.
 2019-10-02 15:28:21 +00:00
Clownacy
5329a6d1b7 ...goddammit I didn't save 2019-10-02 15:25:43 +00:00
Clownacy
8f6403f233 Catch another instance of Shift-JIS 
Also removed the translation because it's ASM-inaccurate
 2019-10-02 15:24:36 +00:00
Clownacy
a8fb0839fa Note Shift-JIS strings 2019-09-28 15:35:41 +00:00
Clownacy
99f9629376 Remove the SHIFT-JIS from the stage table 
Clang never stops complaining about it, so instead we just use raw
hex values, and have the original Japanese in UTF-8 as a comment.
 2019-09-27 15:16:12 +00:00
Clownacy
7bf3109019 Cast X_TO_UNITS and UNITS_TO_X values to int 
This shuts up some MSVC warnings about implicitly casting doubles to
ints when the macros' results are assigned to variables.
 2019-09-25 17:29:22 +01:00
Clownacy
d2df9d9104
Merge pull request #55 from GabrielRavier/commentArmsItem 
Comment ArmsItem
 2019-09-25 16:45:10 +01:00
Gabriel Ravier
a67700d927
Clarify vague comment 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-09-24 10:12:05 +02:00
Gabriel Ravier
bf1239c4a1
Commented all members of ARMS 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-09-24 09:32:21 +02:00
Gabriel Ravier
6645b85139
Change gArmsEnergyX stuff from hexadecimal to decimal. Also commented some more stuff. 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-09-24 09:30:44 +02:00
Gabriel Ravier
b2b9d8ab12
Used tabs instead of spaces before trailing comments 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-09-23 20:29:09 +02:00
Gabriel Ravier
417fce45b3
Fixed other static function 2019-09-23 20:25:55 +02:00
Gabriel Ravier
e2c7ea8996
Left long lines long instead of making them take several lines 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-09-23 20:22:49 +02:00
Gabriel Ravier
818640781b
Fixed switch formatting 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-09-23 20:18:49 +02:00
Gabriel Ravier
5ca917bc97
Removed usage of TILES_TO_PIXELS/PIXELS_TO_TILES in PutCampObject 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-09-23 20:16:09 +02:00
Gabriel Ravier
07dc0aff9f
Removed static from MoveArmsCursor to fix function ordering 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-09-23 20:12:20 +02:00
Gabriel Ravier
e5e01b2b3e
Re-added accidentally removed spacing 
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
 2019-09-23 19:59:16 +02:00