Commit graph

61 commits

Author SHA1 Message Date
Clownacy
7b1661dcf9 Merge branch 'accurate' into portable 2020-09-04 01:00:17 +01:00
Clownacy
5579c57738 Remove some explicit array sizes
These are just annoying, and chances are the source code never did
this.

I might just remove *all* of these at some point.
2020-09-04 00:54:23 +01:00
Clownacy
4caa023347 Merge branch 'accurate' into portable 2020-09-04 00:49:45 +01:00
Clownacy
c81829e99a Remove a trailing comma
IIRC C89 doesn't allow them in enums. So who knows where else they're
not allowed?
2020-09-04 00:23:07 +01:00
Clownacy
9bba04b395 Rename some background enums 2020-09-04 00:19:49 +01:00
Clownacy
d16aa4cc70 Apply background constants to stage table 2020-09-04 00:09:38 +01:00
Clownacy
fe7765c914 Change some awkward wording 2020-09-03 23:57:07 +01:00
Clownacy
d5cf991733 Make the stage table neater 2020-09-03 23:56:44 +01:00
Gabriel Ravier
32c8795ead src: Cleaned up includes to only (and always) include what we use
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2020-07-01 18:26:22 +02:00
Clownacy
56bf0f8c76 Fix some typos 2020-06-30 13:52:11 +01:00
Clownacy
27a1fd900f Revert more unnecessary edits 2020-06-30 13:48:46 +01:00
Gabriel Ravier
771b944d17 src: Some cleanup for the MAX_PATH std::string PR
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2020-06-29 19:02:25 +02:00
Gabriel Ravier
564d42dbd2 src: Change from using asprintf-based code to using std::string-based code
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2020-06-29 18:33:22 +02:00
Gabriel Ravier
32a879ca58 src: Removed MAX_PATH and made the path/string handling better in general (ported over from supportPathsAboveFilenameMax)
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2020-06-29 00:14:30 +02:00
Clownacy
2f682a102f Merge branch 'accurate' into portable 2020-05-04 18:17:39 +01:00
Clownacy
03250d62a0 Make variables more accurate
This commit changes which variables are static: the Mac (and
presumably the Linux) debug data tells you what variables are static,
by prefixing their names with double_underscores.

The variable names themselves also hint at this: global variables are
prefixed with 'g', and use upper-camelcase, while static variables
use whatever_you_call_this.
2020-05-03 20:28:56 +01:00
Clownacy
d80d7ed8c8 Merge branch 'accurate' into portable 2020-03-14 19:26:39 +00:00
Clownacy
169a755ec3 Wrap UTF-8 strings in C89-style comments
This should prevent compilation errors when compilers don't read the
source files as UTF-8.

MSVC in certain codepages previously misread some UTF-8 comments as
containing newlines, causing it to try to process the rest of the
comment as code. This was fixed by forcing MSVC to read the files as
UTF-8 using the `/utf-8` flag, but this doesn't seem to be supported
in older versions.

Since the issue was caused by newlines being added where they didn't
belong, using C89-style comments instead should avoid the problem
altogether.

I'll still keep the utf-8 flag around for supported compilers - just
in case.
2020-03-14 14:12:53 +00:00
Clownacy
9cbaa0be00 Merge branch 'accurate' into portable 2020-01-08 13:16:21 +00:00
Clownacy
3f2d5c3e25 More-accurate Stage.cpp variable arrangement 2020-01-07 22:08:10 +00:00
Clownacy
84626ea710 Merge branch 'accurate' into portable 2020-01-07 04:55:16 +00:00
Clownacy
fb8ba25d0f Made Stage.cpp valid C89
See #41
2020-01-06 20:57:20 +00:00
Clownacy
0ec5d85d56 Merge branch 'accurate' into portable 2019-11-17 18:30:44 +00:00
Clownacy
156e47438c Stage.cpp cleanup 2019-11-14 00:23:50 +00:00
Clownacy
8344716548 Merge branch 'accurate' into portable 2019-11-09 14:24:55 +00:00
Gabriel Ravier
401a8f0d42 Bug : Fix wrong == to != 2019-11-06 20:21:56 +01:00
Gabriel Ravier
bae879e3b5 Check "no" against MUS_SILENCE instead of converting it to a bool
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-05 17:27:04 +01:00
Clownacy
c759498169 Merge branch 'accurate' into portable 2019-09-27 15:20:56 +00:00
Clownacy
99f9629376 Remove the SHIFT-JIS from the stage table
Clang never stops complaining about it, so instead we just use raw
hex values, and have the original Japanese in UTF-8 as a comment.
2019-09-27 15:16:12 +00:00
Clownacy
54b3cd9c11 Revert "Add the typos back to the stage table"
This reverts commit 5dd3a5dd2d.

Obviously don't want these
2019-09-05 15:20:03 +01:00
Clownacy
8916ee7dd8 Merge branch 'accurate' into portable 2019-09-05 15:16:29 +01:00
Clownacy
5dd3a5dd2d Add the typos back to the stage table
These were corrected in an earlier commit because they affect
portability.
2019-09-05 14:56:03 +01:00
Clownacy
5b5d5ae729 Revert "Restore the Windows-style path separators"
This reverts commit 42e1b36fd8.
2019-09-05 14:19:17 +01:00
Clownacy
84c3cd825e Merge branch 'accurate' into portable 2019-09-05 14:18:42 +01:00
Clownacy
42e1b36fd8 Restore the Windows-style path separators 2019-09-05 14:05:27 +01:00
Clownacy
4e50046d4b Remove WINDOWS and NONPORTABLE
Now that the portable stuff gets its own branch, these are unneeded
2019-09-04 02:14:15 +01:00
Clownacy
73e18b4610 Removed the WINDOWS and NONPORTABLE stuff
Now that all the ASM-accurate stuff is in its own branch, we don't
need these anymore.
2019-09-04 00:54:11 +01:00
Clownacy
03e513365b PATH_LENGTH is actually Windows's MAX_PATH
When MAX_PATH isn't available, use FILENAME_MAX. This might be a bad
idea.
2019-08-31 01:44:53 +01:00
Clownacy
b7d01aae3f Overhauled the Music ID enum
This should be ASM-accurate, since SurfaceID was
2019-08-21 18:26:20 +00:00
Clownacy
c80b593a3f Some #include fixes
Finally figured out how to get include-what-you-use working
2019-06-06 18:44:28 +00:00
Clownacy
676ee004fe Removed the dependency on stdint.h
This doesn't exist in MSVC2003, and nothing in the Linux port's debug
symbols indicate Pixel used it.
2019-05-13 15:18:33 +01:00
Clownacy
f8d4ae7014 Made Stage.cpp ASM-accurate 2019-05-07 13:52:50 +01:00
Gabriel Ravier
960fa6f456 Removed all trailing spaces and added newline at EOF (when not present)
Also changed a "linux" to "Linux"

Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-05-07 11:55:42 +02:00
Clownacy
58a3974e1a Added an accuracy improvement
It affects portability though, so it's hidden behind the NONPORTABLE
flag.
2019-05-04 21:39:16 +00:00
Clownacy
3e5f44f8de Changed some things to BOOL/BOOLEAN, for ASM-accuracy 2019-02-22 22:23:57 +00:00
Clownacy
0bb9760d87 Rearranged #includes 2019-02-18 21:30:22 +00:00
Clownacy
e5caff593c Removed the SDL dependency from Draw.h
Should make compiling with VC++ 2003 simpler
2019-02-18 20:40:07 +00:00
Clownacy
99474e4aef Fix another capitalisation error in the stage table
Should probably stick these fixes in FIX_BUGS at some point...
2019-02-17 00:43:38 +00:00
Clownacy
ef46088671 Removed leftover SDL_rwops includes 2019-02-16 12:50:58 +00:00
cuckydev
de6bf5209c whimsical star done 2019-02-03 13:41:15 -05:00