Commit graph

1508 commits

Author SHA1 Message Date
Gabriel Ravier
a45592302f Documentation : Commented the fact that "swPlay % 2" is always true
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-09 23:36:09 +01:00
Gabriel Ravier
32d29eb63e Documentation : Note that the fact 96 is already listed results in the condition always being false 2019-11-09 23:36:09 +01:00
Gabriel Ravier
ab4a265cd9 Documentation : Add note about duplicate block of code 2019-11-09 23:36:09 +01:00
Gabriel Ravier
6b1f82e78e Documentation : Document identical function bodies for InitBullet and ClearBullet
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-09 23:36:09 +01:00
Gabriel Ravier
bda9fc391a Documentation : Comment redundant if
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-09 23:36:09 +01:00
Gabriel Ravier
6635cc58ed Documentation : Comment identical case branches in NpcAct280 2019-11-09 23:36:09 +01:00
Gabriel Ravier
6f0ffe546f Documentation : Add note about identical case branches in NpcAct020
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-09 23:36:09 +01:00
Gabriel Ravier
c9e63c7694 Documentation : Document the identical HitMyCharMap case branches 2019-11-09 23:36:08 +01:00
Gabriel Ravier
1891591586 Documentation : Document identical case branches in ActBullet
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-09 23:36:08 +01:00
Gabriel Ravier
7ddcbfaa73 Add note about identical case branches
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-09 23:36:08 +01:00
Gabriel Ravier
347f9282fe Documentation : Commented redundant check
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-09 23:36:08 +01:00
Gabriel Ravier
073a15b41b Documentation : Comment implicit truncation 2019-11-09 23:36:08 +01:00
Gabriel Ravier
fa304081fe Documentation : Add note about irreproductability of __DATE
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-09 23:36:08 +01:00
Clownacy
9c56888ffd Deobfuscare more values 2019-11-09 15:40:15 +00:00
Clownacy
9df9ea76f6 Deobfuscate some code
Still ASM-accurate
2019-11-09 15:19:34 +00:00
Clownacy
266bb13be2 Compare some pointers to NULL
Doesn't affect ASM-accuracy - I just think it looks neater.
2019-11-09 14:53:34 +00:00
Clownacy
5026964d98 Fix some more incorrectly-decompiled code 2019-11-09 14:48:11 +00:00
Clownacy
e34f492418 Accuracy fixes for Igor
Includes an ASM-accuracy fix I somehow missed before.
2019-11-09 14:39:23 +00:00
Clownacy
8344716548 Merge branch 'accurate' into portable 2019-11-09 14:24:55 +00:00
Clownacy
3c9ff22c22 Add better error-handling to Font.cpp
Co-authored-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-09 14:19:26 +00:00
Clownacy
cb87f05057
Merge pull request #77 from GabrielRavier/cmpUnclear
Make cmp usage clearer
2019-11-09 14:05:04 +00:00
Clownacy
bac98f7402
Merge pull request #81 from GabrielRavier/surroundMacroWithParentheses
Surrounded the IS_COMMAND macro with parentheses
2019-11-09 14:00:14 +00:00
Clownacy
69ec37c1cc
Merge pull request #82 from GabrielRavier/correctEnumTypeBeingConvertedToBool
Check "no" against MUS_SILENCE instead of converting it to a bool
2019-11-09 13:54:42 +00:00
Gabriel Ravier
401a8f0d42 Bug : Fix wrong == to != 2019-11-06 20:21:56 +01:00
Gabriel Ravier
571a7ca723 Bug : Put parentheses around IS_COMMAND and its parameters
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-05 17:33:16 +01:00
Gabriel Ravier
bae879e3b5 Check "no" against MUS_SILENCE instead of converting it to a bool
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-05 17:27:04 +01:00
Gabriel Ravier
f96b7fa566 Use "memcmp(a, b) != 0" instead of "memcmp(a, b)" so it's clearer we're searching for a difference
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-05 17:25:08 +01:00
Gabriel Ravier
053770b81b Use "strcmp(a, b) != 0" so it's clearer what we're checking for
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-05 10:51:32 +01:00
Gabriel Ravier
3c920996b8 Make memcmp usage clearer
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-05 10:43:09 +01:00
Clownacy
4e322f25c4
Merge pull request #74 from GabrielRavier/parenthesizeFlagsMacros
Parenthesize flag macros
2019-11-04 19:08:30 +00:00
Clownacy
6408303c53
Merge pull request #71 from GabrielRavier/removeNonExistentNameCollisions
Remove undefs in WindowsWrapper
2019-11-04 19:05:56 +00:00
Gabriel Ravier
adc4f99c5a Remove the undefs in WindowsWrapper, as these have no purpose here (no collisions with accurate)
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-04 15:07:20 +01:00
Gabriel Ravier
159bc5d869 Documentation : Make operator priority clearer)
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-04 11:42:34 +01:00
Clownacy
319e416592 Comment-out some unneeded dependencies 2019-11-02 21:20:24 +00:00
Clownacy
85f8d24789 ALL_WARNINGS -> WARNINGS_ALL in .travis.yml 2019-11-02 21:11:54 +00:00
Clownacy
a1ec78211f Added Travis CI badge thingy 2019-11-02 21:03:58 +00:00
Clownacy
84b0cc0e0c
Merge pull request #68 from GabrielRavier/travisCIv2
Add Travis-CI integration
2019-11-02 20:21:16 +00:00
Clownacy
1d005fcb8b
Merge branch 'portable' into travisCIv2 2019-11-02 20:20:17 +00:00
Clownacy
2cc6d1d758 Update warning option names in Makefile 2019-11-02 20:17:21 +00:00
Gabriel Ravier
8c6f1381f0 Add Discord supoprt
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-01 19:20:28 +01:00
Gabriel Ravier
d3a1e74fac Travis-CI : Attempt to remove manual building from source of SDL2
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-01 18:20:47 +01:00
Gabriel Ravier
87c8ae2428 Travis-CI : Fixed fltk package name
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-01 16:44:13 +01:00
Gabriel Ravier
7dc506a92e Travis-CI : Added dev packages which might just fix the build
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-01 16:40:38 +01:00
Clownacy
9b55660c05
Merge pull request #67 from GabrielRavier/fixMakefile
Actually properly fix the Makefile
2019-11-01 14:55:59 +00:00
Gabriel Ravier
2706480645 Actually properly fix the Makefile
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-01 15:53:23 +01:00
Gabriel Ravier
f015ebec79 Add parenthesis at end of comment
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-01 15:40:13 +01:00
Gabriel Ravier
6136911976 Try to fix Makefile by using spaces instead of tabs
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-01 15:28:05 +01:00
Gabriel Ravier
33d734cb17 Use $(warning message) instead of e@cho
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-01 15:07:29 +01:00
Gabriel Ravier
d5099a094b Attempt to fix Travis-CI build
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-01 14:21:39 +01:00
Gabriel Ravier
bc448d0de6 Remove extraneous comma in Makefile
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-11-01 13:59:31 +01:00