Commit graph

1060 commits

Author SHA1 Message Date
Gabriel Ravier
e5e01b2b3e
Re-added accidentally removed spacing
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-23 19:59:16 +02:00
Gabriel Ravier
3f6c744e16
Re-added accidentally removed statement
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-23 19:57:00 +02:00
Gabriel Ravier
ba8f2138b8
Finished commenting ArmsItem basically
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-23 19:52:34 +02:00
Gabriel Ravier
4fc38593d2
More comments in ArmsItem
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-23 19:47:34 +02:00
Gabriel Ravier
b4ef218dca
Removed unnecessary "and" from comment
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-23 10:34:07 +02:00
Gabriel Ravier
d73f82cfcf
Removed wrong FIX_BUGS
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-23 10:32:23 +02:00
Gabriel Ravier
c94d1f1379
Corrected some comments in ArmsItem
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-23 09:25:55 +02:00
Gabriel Ravier
6cd2a49829
Corrected comment
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-23 08:46:38 +02:00
Gabriel Ravier
9d8018e901
More comments in ArmsItem
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-23 07:28:48 +02:00
Gabriel Ravier
eb46198635
Add some comments for the searching of codes
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-21 20:06:09 +02:00
Gabriel Ravier
f6ed183687
Remove macros for searching for codes
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-21 20:04:54 +02:00
Gabriel Ravier
986ab280e4
Revert change from GAME_FLAG_IS_CONTROL_ENABLED to GAME_FLAG_IS_CONTROL_DISABLED and clarify its documentation
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-21 19:26:58 +02:00
Gabriel Ravier
337c81da4d
Changed GAME_FLAG_IS_CONTROL_ENABLED to GAME_FLAG_IS_CONTROL_DISABLED
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-21 18:48:12 +02:00
Gabriel Ravier
63a8385c54
Documented bit 2 of g_GameFlags
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-21 18:40:24 +02:00
Gabriel Ravier
ac5439cdf5
Added TBD notes to GameFlag enum
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-21 15:25:36 +02:00
Gabriel Ravier
f68ee5c4e5
Added an enum for g_GameFlags and a few comments in CampLoop
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-21 15:22:42 +02:00
Gabriel Ravier
7de9ecf1e7
Some commenting
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-21 12:14:17 +02:00
Gabriel Ravier
55cc349dd6
Moar commenting stuff
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-20 20:25:51 +02:00
Gabriel Ravier
453ce04e8b
Added a few comments and a newline
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-20 19:16:31 +02:00
Gabriel Ravier
79d8e175a2
Documented some variables and macro-ed some stuff
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-19 10:30:14 +02:00
Gabriel Ravier
6a9abb9a0d
Moar commenting of stuff and macro-ing of certain things
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-18 08:29:20 +02:00
Gabriel Ravier
372872eeea
Some comments and a FIX_BUGS
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-17 11:54:00 +02:00
Gabriel Ravier
38a00ec88a
More tabs to spaces for trailing comments
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-17 11:09:29 +02:00
Gabriel Ravier
3a837a1090
Commented some code
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-17 11:04:30 +02:00
Gabriel Ravier
4766172c3b
Replaced tabs before comments with spaces, shortened a few lines and formatted some switches
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-17 10:48:05 +02:00
Gabriel Ravier
6ffc8d7429
Shorten long line
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-17 10:31:07 +02:00
Gabriel Ravier
f2a2b3fd0c
Commented some func decls in ArmsItem.h and changed a "32" to "0x20" in the cpp
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-17 10:25:18 +02:00
Gabriel Ravier
9bb916e99d
Set PutCampObject as static and commented some func decls
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-17 09:56:33 +02:00
Gabriel Ravier
358423aa38
Some nice commenting and reordering of stuff and staticing of stuff
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-16 15:30:38 +02:00
Clownacy
602315fa39 Deobfuscate a value without affecting ASM
Doing 'fx / 32 / 0x200' produces different assembly.
2019-09-15 18:46:52 +01:00
Clownacy
bc5a9b2d9f These macros produced inaccurate assembly 2019-09-15 18:44:03 +01:00
Clownacy
a55361ec2c
Merge pull request #54 from GabrielRavier/commentBalfrog
Comment BossFrog
2019-09-15 18:43:42 +01:00
Gabriel Ravier
cc4de5e44c
Remove NPC utility macros
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-15 18:16:46 +02:00
Clownacy
f099e0694d Enable optimisations in the VS2017 project
Honestly, it might be worth remaking the VS2017 project from scratch:
the current one is just a conversion of the VS2003 one, so a lot of
VS2017's new options are just blank. If it's remade from scratch,
we'll get the defaults instead.
2019-09-15 15:41:56 +01:00
Gabriel Ravier
c68923fdd5
Corrected erroneous "PIXELS_TO_UNITS(24)"s to "PIXELS_TO_UNITS(20)"s
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-15 16:13:13 +02:00
Gabriel Ravier
c9517bffc4
Un-abbreviated "SPRITE" from "SPRT" in sprite macro names
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-15 16:10:46 +02:00
Gabriel Ravier
0cf2a20a9a
Corrected erroneous PIXELS_TO_UNITS(32) to PIXELS_TO_UNITS(16)
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-15 16:07:03 +02:00
Gabriel Ravier
9e5e2a0e26
Indented some comments
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-15 16:05:24 +02:00
Gabriel Ravier
002e0f7760
Changed erroneous "=" to "+="
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-15 16:00:06 +02:00
Gabriel Ravier
58a02a609c
Defined TILES_TO_UNITS and UNITS_TO_TILES in terms of TILES_TO_PIXELS, PIXELS_TO_TILES, PIXELS_TO_UNITS and UNITS_TO_PIXELS
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-15 15:58:04 +02:00
Gabriel Ravier
04113870a5
Removed tiles comments when useless
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-15 15:51:32 +02:00
Gabriel Ravier
6eadf6c4a5
Changed view stuff to be measured in pixels, not tiles
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-15 14:16:44 +02:00
Gabriel Ravier
08131d527a
Converted hitbox measurements to pixels
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-15 14:12:35 +02:00
Gabriel Ravier
4070f1b972
Changed some stuff to conform to Clownacy's PR review
Changed BalfrogAnims to BalfrogSprites
Changed BALFANI_[name] to BALFROG_SPRT_[name]
Changed -[macro](val) to [macro](-val)

Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-15 10:58:55 +02:00
Gabriel Ravier
0d833b38a8
Prevent some annoying warnings popping up everywhere
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-15 10:50:46 +02:00
Gabriel Ravier
fcc1e3cc23
Added some common macro utilities used by most NPCs
I'm pretty sure Pixel didn't actually use macros for this but I don't think just having this kind of stuff copied around everywhere is really great either

Forgot to commit and push this yesterday

Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-15 10:48:18 +02:00
Gabriel Ravier
041bd0e5f9
Used doubles for TILES_TO_UNITS weirdly written stuff
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-14 20:47:28 +02:00
Gabriel Ravier
ac498c2be4
After intense debate with Cucky and BLink, ended up changing "PIXELS_TO_UNITS(3) - 1" to "0x5FF"
🙄

Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-14 20:07:35 +02:00
Gabriel Ravier
e2c57e6dbc
Alphabetized macros in BossFrog and re-ordered some stuff to go along with Clownacy's coding standards
Also changed NPC_NULL_DELETES_ITSELF to NPC_DAMAGE_TEXT_HOLDER as Fayti pointed out the misnomer

Note to self : Make a PR with coding standards

Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
2019-09-13 20:35:37 +02:00
Gabriel Ravier
aeb1e292b7
Merge branch 'accurate' into commentBalfrog 2019-09-13 19:01:03 +02:00